Skip to content

MODDATAIMP-1275: Use GitHub Workflows for Maven#385

Merged
dcrossleyau merged 3 commits into
masterfrom
MODDATAIMP-1275
Apr 24, 2026
Merged

MODDATAIMP-1275: Use GitHub Workflows for Maven#385
dcrossleyau merged 3 commits into
masterfrom
MODDATAIMP-1275

Conversation

@KaterynaSenchenko

@KaterynaSenchenko KaterynaSenchenko commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

@KaterynaSenchenko KaterynaSenchenko self-assigned this Apr 16, 2026
@dcrossleyau

dcrossleyau commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

But it has a failing build step. Why have people approved this?

@dcrossleyau

dcrossleyau commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

I did try "Re-run" jobs which failed after a very long time.

The "Build" job has an "Explain error" button, where Copilot does suggest some source-code change. Perhaps that will help.

If you reckon that it is not a development issue then you can raise a ticket and explain the symptoms, and tell Slack folio-devops. There is no point assigning to me, as i cannot assist.

@funkymalc

funkymalc commented Apr 21, 2026

Copy link
Copy Markdown

The maven test phase is failing due to a problem starting the localstack/localstack:s3-latest container. According to the build log:

2026-04-17 16:00:45,040 INFO  GenericContainer     Container localstack/localstack:s3-latest is starting: e59f045028528470757f9d98483a6c554d7cf5444fa734ed2eec06a41d75f408
2026-04-17 16:01:45,242 ERROR GenericContainer     Could not start container
java.lang.IllegalStateException: Wait strategy failed. Container exited with code 127
...
Caused by: org.testcontainers.containers.ContainerLaunchException: Timed out waiting for log output matching '.*Ready\.
...
2026-04-17 16:01:45,269 ERROR GenericContainer     Log output from the failed container:
sh: /testcontainers_start.sh: not found

@funkymalc

funkymalc commented Apr 21, 2026

Copy link
Copy Markdown

Interesting output when I attempt to start this container on my local system:

$ docker run -d localstack/localstack:s3-latest
1c4629676ea49bf76386ed4b59432e5e1a62d0e5b009853f77b4710ce2eb91d2
malc@Johns-MacBook-Pro Downloads $ docker logs 1c4629676ea49bf76386ed4b5
ERROR
============================================================================
  The LocalStack Docker image you started (localstack/localstack:s3-latest)
  is no longer available.
  This image was discontinued with the release of v2026.03 on 
  23rd March 2026. Please switch to localstack/localstack-pro.

  See: https://blog.localstack.cloud/localstack-for-aws-release-2026-03-0/
============================================================================

@sonarqubecloud

sonarqubecloud Bot commented Apr 23, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

dcrossleyau
dcrossleyau approved these changes Apr 24, 2026
View reviewed changes

@dcrossleyau dcrossleyau left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hooray, a green run. I have re-configured the branch protection checks, and will merge.

@dcrossleyau dcrossleyau merged commit 1adcef6 into master Apr 24, 2026
16 checks passed
@dcrossleyau dcrossleyau deleted the MODDATAIMP-1275 branch April 24, 2026 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dcrossleyau dcrossleyau dcrossleyau approved these changes
@Aliaksandr-Fedasiuk Aliaksandr-Fedasiuk Aliaksandr-Fedasiuk approved these changes
@RuslanLavrov RuslanLavrov RuslanLavrov approved these changes

Assignees

@KaterynaSenchenko KaterynaSenchenko

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@KaterynaSenchenko @dcrossleyau @funkymalc @Aliaksandr-Fedasiuk @RuslanLavrov